Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: key-spacing loc changes for extra space (refs #12334) #13362

Merged
merged 2 commits into from Jun 11, 2020
Merged

Update: key-spacing loc changes for extra space (refs #12334) #13362

merged 2 commits into from Jun 11, 2020

Conversation

anikethsaha
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[X] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Changed the location for key-spacing when there are extra space.

ref #12334

Before
image

after
image

image

Is there anything you'd like reviewers to focus on?

None

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label May 26, 2020
@azure-pipelines
Copy link

There was an error handling pipeline event 120db0a6-8ab9-4c0e-8786-06f31717e7c4.

@mdjermanovic mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules and removed triage An ESLint team member will look at this issue soon labels May 26, 2020
@golopot golopot mentioned this pull request May 26, 2020
Closed
kaicataldo
kaicataldo suggested changes Jun 5, 2020
View reviewed changes
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo :)

lib/rules/key-spacing.js Outdated Show resolved Hide resolved
lib/rules/key-spacing.js Outdated Show resolved Hide resolved
@anikethsaha @kaicataldo
Chore: Fixed typo in variable name.
505d02a 
Co-authored-by: Kai Cataldo <kai@kaicataldo.com>
kaicataldo
kaicataldo approved these changes Jun 8, 2020
View reviewed changes
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kaicataldo kaicataldo merged commit 2a21049 into eslint:master Jun 11, 2020
@anikethsaha anikethsaha deleted the fixes-12334-key-spacingg branch June 11, 2020 17:57
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Dec 9, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kaicataldo kaicataldo kaicataldo approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anikethsaha @kaicataldo @mdjermanovic