Update: max-lines reporting loc improvement (refs #12334)

[anikethsaha]

Prerequisites checklist

• I have read the contributing guidelines.
• The team has reached consensus on the changes proposed in this pull request. If not, I understand that the evaluation process will begin with this pull request and won't be merged until the team has reached consensus.

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[X] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Currently max-lines reports 1:1 for any numbers of line.
In this change, it will report the extra lines which are causing the error.

Example :

It will report from (loc.start) 2 and till (loc.end) 3 (total lines)

Is there anything you'd like reviewers to focus on?

refs #12334

---

This can be a bit more red lines as it will goes till eof.

One other option is that to report only the line from where the rest lines are extra. like in this case it would be the Line 3.

Let me know which one to keep.

[mdjermanovic]

I left a comment about what should be fixed if we decide to highlight the extra lines (or just the first extra line), but it could be fairly complex to do this correctly and I'm not sure if reporting the first offending line provides enough value to justify the added complexity.

[mdjermanovic]

I missed the fact that we're already filtering out ignored lines instead of just counting them, so it turns out that this doesn't add much complexity.

Also, I'm still not sure that we want to find and report the first line that goes above the limit since we're not doing that in other similar rules (e.g., max-lines-per-function), but in the case that we do that, I left some notes about what should be changed in the actual iteration.

[anikethsaha]

update :

[kaicataldo]

@mdjermanovic Do you mind taking one more look?

[mdjermanovic]

The code looks good! I have just a couple of small requests about tests.

[mdjermanovic]

LGTM, thanks!