Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: Improve report location for linebreak-style (refs #12334) #13317

Merged
merged 1 commit into from May 20, 2020
Merged

Update: Improve report location for linebreak-style (refs #12334) #13317

merged 1 commit into from May 20, 2020

Conversation

mdjermanovic
Copy link
Member

Prerequisites checklist

  • I have read the contributing guidelines.
  • The team has reached consensus on the changes proposed in this pull request. If not, I understand that the evaluation process will begin with this pull request and won't be merged until the team has reached consensus.

What is the purpose of this pull request? (put an "X" next to an item)

[X] Other, please explain:

refs #12334

Change reported location in the linebreak-style rule.

What changes did you make? (Give an overview)

Added start of the next line as the end location.

Before this change:

image

After this change:

image

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic added enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules accepted There is consensus among the team that this change meets the criteria for inclusion labels May 18, 2020
@golopot golopot mentioned this pull request May 18, 2020
Closed
yeonjuan
yeonjuan approved these changes May 20, 2020
View reviewed changes
Copy link
Member

@yeonjuan yeonjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@kaicataldo kaicataldo merged commit 89e1081 into master May 20, 2020
@kaicataldo kaicataldo deleted the linebreakstyle-loc branch May 20, 2020 16:35
@kaicataldo
Copy link
Member

Thank you for contributing!

@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Nov 17, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Nov 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kaicataldo kaicataldo kaicataldo approved these changes

@yeonjuan yeonjuan yeonjuan approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mdjermanovic @kaicataldo @yeonjuan