New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
devdeps: leche has been deprecated #13287
Comments
Switching to Jest doesn't make sense just to update this small dependency. I'm not sure we need to change anything if our tests are still working, but if we do want to change something, I'd just keep it local to the tests using the dependency. |
Agreed with @nzakas. We only use
We should be able to replace it by:
Example (based on these tests): [
["let foo", true],
["let foo", true],
["let /**/ foo", true],
["let/**/foo", false],
["let/*\n*/foo", false]
].forEach(([code, expected]) => {
describe("when the first given is located before the second", () => {
it(code, () => {
const ast = espree.parse(code, DEFAULT_CONFIG),
sourceCode = new SourceCode(code, ast);
assert.strictEqual(
sourceCode.isSpaceBetween(
sourceCode.ast.tokens[0],
sourceCode.ast.tokens[sourceCode.ast.tokens.length - 1]
),
expected
);
});
});
}); |
Unfortunately, it looks like there wasn't enough interest from the team Thanks for contributing to ESLint and we appreciate your understanding. |
To reopen this, we should have a plan for addressing it. If not, we should close it. |
Anyway, it is discouraged to keep using unmaintained packages. And @kaicataldo 's comment seems like a good direction. thoughts? |
I originally wrote leche, so I’m not very concerned about continuing to use it. @kaicataldo‘s suggestion is fine too. I just don’t want to leave this open without a plan. |
@aladdin-add Do you want to work on this? This could also be a good opportunity for a community contribution :) |
going to look into this |
Thanks @peanutenthusiast! |
…gnore-default-values * upstream/master: (66 commits) Sponsors: Sync README with website Sponsors: Sync README with website Sponsors: Sync README with website Sponsors: Sync README with website Sponsors: Sync README with website Chore: remove leche (fixes eslint#13287) (eslint#13533) Sponsors: Sync README with website Sponsors: Sync README with website 7.6.0 Build: changelog update for 7.6.0 Update: require `meta` for fixable rules in RuleTester (refs eslint#13349) (eslint#13489) Docs: fix broken links in developer guide (eslint#13518) Fix: Do not output `undefined` as line and column when it's unavailable (eslint#13519) Sponsors: Sync README with website Sponsors: Sync README with website Fix: Update the chatroom link to go directly to help channel (eslint#13536) Sponsors: Sync README with website Update: Change no-duplicate-case to comparing tokens (fixes eslint#13485) (eslint#13494) Docs: add ECMAScript 2020 to README (eslint#13510) 7.5.0 ...
The version of ESLint you are using.
v7.0.0(latest)
The problem you want to solve.
https://github.com/box/leche#deprecated
Your take on the correct solution to problem.
do we want to switch to jest, or just find an alternative?
Are you willing to submit a pull request to implement this change?
y
The text was updated successfully, but these errors were encountered: