Fix: astUtils.getNextLocation returns invalid location after CRLF #13275
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[X] Bug fix
Tell us about your environment
What parser (default, Babel-ESLint, etc.) are you using?
default
Please show your full configuration:
Configuration
What did you do? Please include the actual source code causing the issue.
CRLF after
foo
andbar
What did you expect to happen?
Two errors with the following locations (1-based lines and 1-based columns):
foo
: "line":3,"column":4, "endLine":4,"endColumn":1bar
: "line":4,"column":4, "endLine":5,"endColumn":1What actually happened? Please include the actual, raw output from ESLint.
Two errors with the following locations (1-based lines and 1-based columns):
foo
: "line":3,"column":4, "endLine":3,"endColumn":5bar
: "line":4,"column":4, "endLine":4,"endColumn":5endColumn: 5
would be a position between CR and LF.VS Code treats this as if no endColumn was given, and underlines word before the start column:
Atom explicitly reports invalid position:
What changes did you make? (Give an overview)
Fixed
astUtils.getNextLocation
to return the start of the next line instead of an invalid location between CR and LF.This affects the following rules at the moment:
semi
comma-dangle
Is there anything you'd like reviewers to focus on?