Update: Improve report location for template-tag-spacing (refs #12334)

[mdjermanovic]

Prerequisites checklist

• I have read the contributing guidelines.
• The team has reached consensus on the changes proposed in this pull request. If not, I understand that the evaluation process will begin with this pull request and won't be merged until the team has reached consensus.

What is the purpose of this pull request? (put an "X" next to an item)

[X] Other, please explain:

refs #12334

Change reported location in the template-tag-spacing rule.

What changes did you make? (Give an overview)

For "always", the rule will now report the full location of the first token before the template literal, instead of just its start.

For "never", the rule will now report range between the first token before the template literal and the template literal, instead of start of the first token before the template literal,

"always" before this change:

"always" after this change:

"never" before this change:

"never" after this change:

Is there anything you'd like reviewers to focus on?

[nzakas]

Thanks for doing this. For “always”, I think I’d prefer the parens and “foo” all be underlined so it matches what happens without parens.

[mdjermanovic]

Thanks for doing this. For “always”, I think I’d prefer the parens and “foo” all be underlined so it matches what happens without parens.

This can be done by reporting range from the start to the quasi, which is basically everything that makes the tag in a tagged template literal.

Some examples:

and a typescript example with generics:

Does it look okay, or is it maybe underlining too much code?

Another alternative might be to report loc of the left backtick.

[kaicataldo]

Another alternative might be to report loc of the left backtick.

This makes sense to me!

[nzakas]

I still like my suggestion better. :) It’s difficult time see underlines of just one character.

[mdjermanovic]

"always" is changed now:

[nzakas]

I like it! @kaicataldo are you okay with this?

[kaicataldo]

LGTM, thank you!