Update: fix operator-linebreak overrides schema #13199
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[X] Bug fix
Tell us about your environment
What parser (default, Babel-ESLint, etc.) are you using?
default
Please show your full configuration:
Configuration
What did you do? Please include the actual source code causing the issue.
Online Demo
/*eslint operator-linebreak: ["error", "after", { "overrides": { "+": true } }]*/
What did you expect to happen?
ESLint to report invalid configuration on
true
. This value should be one of["after", "before", "none", "ignore"]
.What actually happened? Please include the actual, raw output from ESLint.
no warnings
What changes did you make? (Give an overview)
Fixed the schema for
overrides
in theoperator-linebreak
rule. The previous schema actually defined allowed enum for the value of a property named"anyOf"
(which doesn't make sense).Also fixed the documentation. This rule has two options, not one option that can be either string or object.
Is there anything you'd like reviewers to focus on?
This invalid configuration had specific behavior, different from the 4 valid options. It works mostly as
"ignore"
, but it also disallows cases where linebreaks are on both sides of the specified operator. Nevertheless, this isn't documented and it doesn't look it was intentional.