Update: add missing additionalProperties: false to some rules' schema

[mdjermanovic]

Prerequisites checklist

• I have read the contributing guidelines.
• The team has reached consensus on the changes proposed in this pull request. If not, I understand that the evaluation process will begin with this pull request and won't be merged until the team has reached consensus.

What is the purpose of this pull request? (put an "X" next to an item)

[X] Bug fix

Tell us about your environment

• ESLint Version: v7.0.0-alpha.3
• Node Version: v12.14.0
• npm Version: v6.13.4

What parser (default, Babel-ESLint, etc.) are you using?

default

Please show your full configuration:

Configuration

module.exports = {
    parserOptions: {
        ecmaVersion: 2015
    }
}

What did you do? Please include the actual source code causing the issue.

Online Demo

/*eslint id-match: ["error", "^[a-z]+([A-Z][a-z]+)*$", { "foo": true }]*/
/*eslint no-unused-vars: ["error", { "foo": true }] */
/*eslint padded-blocks: ["error", "never", { "foo": true }] */

What did you expect to happen?

ESLint to report invalid configuration for all 3 rules, because "foo" isn't an expected property.

This is how almost all rules work, to avoid typos and misconfiguration.

What actually happened? Please include the actual, raw output from ESLint.

no warnings

What changes did you make? (Give an overview)

Added additionalProperties: false to the following rules:

• id-match
• no-unused-vars
• padded-blocks

Is there anything you'd like reviewers to focus on?

I think this kind of fixes should be semver-minor.

[kaicataldo]

I'd like another review before merging, but this makes sense to me and I agree that this should be a semver-minor bug fix.

[btmills]

I agree that this is a semver-minor bugfix. The rest of the rules' schemas establish the precedent that we'll use additionalProperties: false to prevent accidental misconfigurations, and it's unexpected that these three rules didn't have that.