New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: support ??
operator, import.meta, and export * as ns
#13196
Conversation
As for Other than that, I believe the list is complete (
|
@mysticatea is this making it into v7 release? The v7 RC doesn't truly have ESM support right now since almost every ESM Node project has |
@aldeed We are waiting for upstreams. I guess this PR will be landed on v7.1.0 or v7.2.0. |
??
operator, import.meta, and export * as ns
Optional chaining syntax still stays on the spec discussion, but the upstreams have been released along with the other syntax. Therefore, I separated the optional chaining from this PR in order to merge this PR soonly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for doing this @mysticatea! As part of this, I think I finally understand how code path analysis works!
Is the PR title no longer accurate? |
@ljharb optional chaining is the only thing not in this PR. The other three features are included. Is that what you mean? |
Ah ok, so this does include nullish coalescing :-) thanks! |
acornjs/acorn#891 is now merged, so hopefully, we can get back to this soon(ish) (once acorn gets a new release) |
When will this be released for eslint? |
This PR was released in the latest version (v7.2.0). |
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[X] Changes an existing rule and existing core feature
What changes did you make? (Give an overview)
This PR upgrades dependencies and updates rules and code path analysis in order to support new syntax. Refs #12642, fixes #12629, fixes #13133.
Optional Chaining (Add optional chaining estree/estree#204)export * as ns from "source"
(Add exported property to ExportAllDeclaration estree/estree#205)import.meta
(Addimport.meta
to ES2020 estree/estree#210)Optional Chaining (add Optional Chaining acornjs/acorn#891)export * as ns from "source"
(addexport * as ns from "source"
acornjs/acorn#889)import.meta
(addimport.meta
acornjs/acorn#943)Optional Chaining (not yet)??
operator,import.meta
, andexport * as ns
espree#441)export * as ns from "source"
(Update: support??
operator,import.meta
, andexport * as ns
espree#441)import.meta
(Update: support??
operator,import.meta
, andexport * as ns
espree#441)Optional Chaining (not yet)export * as ns from "source"
(Chore: added exported in exportAllDeclaration key eslint-visitor-keys#10)import.meta
(no change)Optional Chaining (not yet)export * as ns from "source"
(Update: support new export syntax eslint-scope#56)import.meta
(no change)Optional Chaining (not yet)export * as ns from "source"
(no change)import.meta
(no change)Optional Chaining (not yet)export * as ns from "source"
(2b6c93b)import.meta
(no change)[EDIT]: Optional chaining is still stuck and acorn has been released with the other parts. Therefore, we separate optional chaining from this PR.
Is there anything you'd like reviewers to focus on?