Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: enable exceptRange option in the yoda rule #12857

Merged
merged 1 commit into from Jun 13, 2020

Conversation

mdjermanovic
Copy link
Member

Prerequisites checklist

  • I have read the contributing guidelines.
  • The team has reached consensus on the changes proposed in this pull request. If not, I understand that the evaluation process will begin with this pull request and won't be merged until the team has reached consensus.

What is the purpose of this pull request? (put an "X" next to an item)

[X] Other, please explain:

Set exceptRange: true for the yoda rule in eslint-config-eslint.

What changes did you make? (Give an overview)

Enabled the option in order to allow code such as this:

0 <= value && value < MAX_ARRAY_LENGTH

Is there anything you'd like reviewers to focus on?

I'm not entirely familiar with the semver policy for eslint-config-eslint. Just to note that this option doesn't enforce anything, so enabling it can produce only fewer warnings.

@mdjermanovic mdjermanovic added evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion chore This change is not user-facing labels Feb 1, 2020
@kaicataldo
Copy link
Member

kaicataldo commented Feb 4, 2020

I'm not entirely familiar with the semver policy for eslint-config-eslint.

Since it's intended for our use, I think we've generally released it when changes go in that we want to share across our codebases. Since this would result in fewer warnings, I think it would be fine to release this in a semver-minor release.

@kaicataldo kaicataldo removed the evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion label Jun 13, 2020
@kaicataldo kaicataldo merged commit c42e548 into master Jun 13, 2020
@kaicataldo kaicataldo deleted the chore-yoda-exceptrange branch June 13, 2020 00:02
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Dec 11, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants