Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: add object option test cases in yield-star-spacing #12679

Merged
merged 1 commit into from Dec 20, 2019
Merged

Chore: add object option test cases in yield-star-spacing #12679

merged 1 commit into from Dec 20, 2019

Conversation

yeonjuan
Copy link
Member

@yeonjuan yeonjuan commented Dec 17, 2019 •
edited

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Added test cases for covering this branch(screenshot) in yield-star-spacing.js.

스크린샷 2019-12-14 오후 7 38 27

This PR increases test coverage for yield-star-spacing

  • Test coverage - yield-star-spacing.js
master PR
Statements 96.55% 100%
Branches 95.45 100%
Functions 100% 100%
Lines 96.55% 100%

What changes did you make? (Give an overview)

Add test cases(object option).

Is there anything you'd like reviewers to focus on?

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Dec 17, 2019
@kaicataldo kaicataldo added chore This change is not user-facing evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion rule Relates to ESLint's core rules accepted There is consensus among the team that this change meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Dec 18, 2019
btmills
btmills approved these changes Dec 20, 2019
View reviewed changes
Copy link
Member

@btmills btmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you for adding these! LGTM.

@btmills btmills merged commit 9986d9e into eslint:master Dec 20, 2019
@yeonjuan yeonjuan deleted the add-test-for-yield-spacing branch January 3, 2020 14:50
This was referenced Jan 12, 2020
Closed
Merged
@snyk-bot snyk-bot mentioned this pull request Feb 13, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Feb 27, 2020
Merged
@a-martynovich a-martynovich mentioned this pull request Mar 10, 2020
Merged
This was referenced Mar 11, 2020
Merged
Open
This was referenced Mar 26, 2020
Merged
Merged
Merged
Open
This was referenced Apr 3, 2020
Merged
Open
Merged
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Jun 19, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jun 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@btmills btmills btmills approved these changes

@kaicataldo kaicataldo kaicataldo approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing rule Relates to ESLint's core rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yeonjuan @btmills @kaicataldo