Closed
Description
Tests pass on master in https://github.com/yannickcr/eslint-plugin-react on v6.6, and fail on v6.7.0 or v6.7.1. https://travis-ci.org/yannickcr/eslint-plugin-react/jobs/616996307 is an example of the failures; they're related to whitespace placement, within jsx.
I'm not sure which item in the changelog might be responsible, but perhaps #12491 (cc @kaicataldo)?
The change doesn't need to be reverted if i have a reliable way in the react plugin to detect the different behavior, but I suspect that's also difficult.
Metadata
Metadata
Assignees
Labels
Type
Projects
Milestone
Relationships
Development
- Fix: isSpaceBetweenTokens() recognizes spaces in JSXText (fixes #12614)eslint/eslint
- [Snyk] Upgrade eslint from 6.7.0 to 6.7.2basics/vector
- [Snyk] Upgrade eslint from 6.7.1 to 6.8.0fisker/eslint-plugin-unicorn
- [Snyk] Upgrade eslint from 6.7.2 to 6.8.0basics/vector
- [Snyk] Upgrade eslint from 6.5.1 to 6.8.0thinkwee/thinkwee.github.io
- [Snyk] Upgrade eslint from 5.15.1 to 6.8.0alxtford/numconv
- [Snyk] Upgrade eslint from 6.0.0 to 6.8.0WoTTsecurity/api
- [Snyk] Upgrade eslint from 6.0.0 to 6.8.0WealthWizardsEngineering/instance-terminator
- [Snyk] Upgrade eslint from 6.3.0 to 6.8.0O330oei/node
- [Snyk] Upgrade eslint from 6.6.0 to 6.8.0nodeshift-archived/rhoaster
Activity
[Tests] temporarily pin eslint 6 tests to v6.6
[Tests] temporarily pin eslint 6 tests to v6.6
mysticatea commentedon Nov 28, 2019
Thank you for your report.
I confirmed it.
As you mentioned, #12491 has changed the behavior of the
isSpaceBetweenTokens()
method about JSXText tokens that contain only spaces.Fix: isSpaceBetween should recognize the spaces in JSXText (fixes #12614
Fix: isSpaceBetween() recognizes spaces in JSXText (fixes #12614)
Fix: isSpaceBetweenTokens() recognizes spaces in JSXText (fixes #12614)…
18 remaining items