Skip to content

v6.7.0 broke autofixing for eslint-plugin-react #12614

Closed
@ljharb

Description

@ljharb
Contributor

Tests pass on master in https://github.com/yannickcr/eslint-plugin-react on v6.6, and fail on v6.7.0 or v6.7.1. https://travis-ci.org/yannickcr/eslint-plugin-react/jobs/616996307 is an example of the failures; they're related to whitespace placement, within jsx.

I'm not sure which item in the changelog might be responsible, but perhaps #12491 (cc @kaicataldo)?

The change doesn't need to be reverted if i have a reliable way in the react plugin to detect the different behavior, but I suspect that's also difficult.

Activity

added
bugESLint is working incorrectly
triageAn ESLint team member will look at this issue soon
on Nov 28, 2019
added
patch candidateThis issue may necessitate a patch release in the next few days
acceptedThere is consensus among the team that this change meets the criteria for inclusion
and removed
triageAn ESLint team member will look at this issue soon
on Nov 28, 2019
mysticatea

mysticatea commented on Nov 28, 2019

@mysticatea
Member

Thank you for your report.

I confirmed it.
As you mentioned, #12491 has changed the behavior of the isSpaceBetweenTokens() method about JSXText tokens that contain only spaces.

added a commit that references this issue on Nov 28, 2019
e6de965
added a commit that references this issue on Nov 28, 2019
8e73ee3
added a commit that references this issue on Nov 30, 2019
bc435a9

18 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
v6.7.0 broke autofixing for eslint-plugin-react · Issue #12614 · eslint/eslint