Update: Allow $schema in config #12612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
eslint-deprecated
bot
added
the
triage
|
@kaicataldo could you give me a hand with this, please 馃檹 |
kaicataldo
added
core
|
Quick note: we generally require core changes to go through the RFC process outlined here, but I personally think this is a small enough change that it might not warrant it. Let's see what the rest of the team thinks. |
|
I also agree that this is a small change. |
ilyavolodin
approved these changes
Dec 10, 2019
|
Agree, this does not require RFC |
|
I'll champion this. @eslint/eslint-team does anyone want's to support it? |
kaicataldo
added
accepted
|
This has now been accepted. |
kaicataldo
approved these changes
Dec 19, 2019
|
Thanks for contributing! |
This was referenced Jan 12, 2020
This was referenced Mar 11, 2020
This was referenced Mar 26, 2020
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[x] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Allowed the usage of
$schemain the configuration. This key is useful for some IDEs to find information about the schema of the JSON 馃し鈥嶁檪Is there anything you'd like reviewers to focus on?
Make sure that I validated the key correctly