Fix: revert changes to key-spacing due to regression #12598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-deprecated
bot
added
the
triage
kaicataldo
changed the title
kaicataldo
added
bug
ilyavolodin
approved these changes
Nov 25, 2019
btmills
approved these changes
Nov 25, 2019
platinumazure
approved these changes
Nov 25, 2019
kaicataldo
added a commit
that referenced
this pull request
Nov 25, 2019
kaicataldo
force-pushed
the
revert-12472
branch
2 times, most recently
from
1c46144
to
b9c0a48
Compare
kaicataldo
force-pushed
the
revert-12472
branch
from
b9c0a48
to
e9c0584
Compare
|
Weird - I had to restore the branch and delete it again to get this to disappear from my "open PRs" list... |
This was referenced Mar 11, 2020
This was referenced Mar 26, 2020
This was referenced Mar 30, 2020
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[X] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
As reported in #12597, this change muddles the meaning of single line and multi line objects in a way that can lead to more errors being reported. This wasn't the intention, and I don't think we should be introducing more errors in a minor release for an autofix bug fix.
I'd like to advocate for reverting this change, releasing a patch release, and revisiting this (with @yeonjuan's help if they're willing!).
Is there anything you'd like reviewers to focus on?
Nothing in particular.