New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New: Include node version in cache #12582
New: Include node version in cache #12582
Conversation
a0ad07a
to
640daec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the widespread use of tools like nvm
, this seems like a good idea to me. Are there any tests we can include to cover this change?
I can add it together with the eslint version. |
Even though this is a core change, it’s such a small one that I don’t think it should have to go through the RFC process. That being said, I think we should bring this to the TSC. |
TSC Summary This PR proposes to include the Node version when hashing the cache key, ensuring that the cache is busted when consecutive linting runs are executed with different Node versions. TSC Question Should we accept this? |
This proposal was accepted at today's TSC meeting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for contributing!
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[x] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Add node version to the key used in cache.
the result from the linting is possible to be different (some rules may fail) when the node is upgraded or downgraded.
Is there anything you'd like reviewers to focus on?
N/A