New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Add GitHub organization to Sponsor button #12562
Conversation
I don't know if we need both. Github org sponsorship goes through OpenCollective (i.e. all the donations through Github will end up in our OpenCollective account). |
It seemed weird to me that the Sponsor button on https://github.com/eslint took me to the GitHub Sponsors page, whereas the Sponsor button on https://github.com/eslint/eslint showed a dialog linking to Open Collective. If we're fine with that, then this PR can be closed. |
@btmills Does this PR resolve the inconsistency you described? |
In theory, merging this would then include the GitHub organization in the Sponsors modal on https://github.com/eslint/eslint, but I can’t verify that ahead of time. My plan, if we want to add this at all, would be to merge this, check the modal, and revert this if it didn’t work. |
I'd love to give users a consistent experience, so I'm 👍 to merging this and testing, but I'll defer to the rest of the team. |
I agree that we should have all the sponsorship links go to the same destination. Could we solve this problem by putting an additional link to Open Collective on our GitHub Sponsors page and point all the Sponsors links in repositories to that? |
@btmills Sorry I wasn't clear. I'm 👍 for adding github as an option, but I think we can remove opencollective from that list, as github will wire all of the money into open collective (basically, github is acting just as an interface). |
For a reference, you can see the preview on https://github.com/eslint/eslint/edit/master/.github/FUNDING.yml |
Nice find @mysticatea . Here's the link to PR change: https://github.com/eslint/eslint/edit/github-sponsors/.github/FUNDING.yml |
Looks like we have consensus from the TSC. Going to merge! |
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:
What changes did you make? (Give an overview)
I added the @eslint organization to
FUNDING.yml
so that the "Sponsor" button on the eslint/eslint repository shows GitHub Sponsors as an option in addition to Open Collective.Is there anything you'd like reviewers to focus on?
The
FUNDING.yml
docs haven't been updated to specifically mention sponsoring teams, so I'm hoping the format for teams is the same as for individual users.