Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Add funding field to package.json #12543

Merged
merged 1 commit into from Nov 8, 2019
Merged

Chore: Add funding field to package.json #12543

merged 1 commit into from Nov 8, 2019

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Nov 7, 2019

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Add the new funding field to package.json. See:

What changes did you make? (Give an overview)

Added funding field to package.json. Note that this field may be an object or a string. I chose to make it a string because the object has redundant information in it (the type of funding can be inferred from the URL).

Is there anything you'd like reviewers to focus on?

Any syntax errors. :)

@nzakas nzakas added the chore This change is not user-facing label Nov 7, 2019
@platinumazure
Copy link
Member

Question: Should we do the same on other projects in the organization?

@nzakas
Copy link
Member Author

nzakas commented Nov 7, 2019

@platinumazure Excellent point! Yes, we should go through and do that on other projects, too. I think Espree is probably the most important one to add it to.

Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nzakas nzakas merged commit 575a98d into master Nov 8, 2019
@nzakas nzakas deleted the fundjson branch November 8, 2019 15:38
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators May 8, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label May 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants