Fix: invalid autofix in function-call-argument-newline (fixes #12454)

[yeonjuan]

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

This is a PR for #12454

• Add checking whether there is a line comment(// comment) before currentArgToken

Is there anything you'd like reviewers to focus on?

[aladdin-add]

LGTM, thanks!

[kaicataldo]

Thanks for contributing! Can we add tests that document that it does autofix block comments? They can be the same tests tests, just with block comments instead of line comments.

[platinumazure]

Looks good, thanks for contributing!

[platinumazure]

@kaicataldo It looks like there are some tests with the "consistent" option which show that the autofix works:

eslint/tests/lib/rules/function-call-argument-newline.js

Lines 423 to 450 in d679dd8

	{
	code: "fn(a,\n\tb /* comment */, c)",
	output: "fn(a,\n\tb /* comment */,\nc)",
	options: ["consistent"],
	errors: [
	{
	messageId: "missingLineBreak",
	line: 2,
	column: 18,
	endLine: 2,
	endColumn: 19
	}
	]
	},
	{
	code: "fn(a,\n\tb, /* comment */ c)",
	output: "fn(a,\n\tb, /* comment */\nc)",
	options: ["consistent"],
	errors: [
	{
	messageId: "missingLineBreak",
	line: 2,
	column: 18,
	endLine: 2,
	endColumn: 19
	}
	]
	},

It may be a good idea to add more tests for other options, but could that potentially be in a separate PR?

[kaicataldo]

Ah, I missed that. Thanks for pointing that out!

[kaicataldo]

LGTM, thanks!

[kaicataldo]

Not a blocker, but I’m assuming the intention was comment rather than commeent here 😄

[yeonjuan]

@kaicataldo Oh it's typo. I fixed it. Thanks.