Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add notice about function keyword in keyword-spacing #12524

Merged
merged 2 commits into from Nov 5, 2019

Conversation

g-plane
Copy link
Member

@g-plane g-plane commented Nov 3, 2019

What is the purpose of this pull request? (put an "X" next to item)

Documentation update

What changes did you make? (Give an overview)

Added notice about function keyword to reduce confusion.

@g-plane g-plane added the documentation Relates to ESLint's documentation label Nov 3, 2019
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion, but otherwise this LGTM!

docs/rules/keyword-spacing.md Outdated Show resolved Hide resolved
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, outside of Kai's requested change. Thanks!

Co-Authored-By: Kai Cataldo <7041728+kaicataldo@users.noreply.github.com>
@kaicataldo kaicataldo merged commit 5868550 into master Nov 5, 2019
@kaicataldo kaicataldo deleted the docs-of-keyword-spacing branch November 5, 2019 00:49
@kaicataldo
Copy link
Member

Thanks for contributing!

@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators May 5, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants