Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: operator-assignment removes and duplicates comments #12485

Merged
merged 1 commit into from Oct 25, 2019

Conversation

mdjermanovic
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[X] Bug fix

This PR fixes operator-assignment to prevent autofix if it would remove or duplicate comments.

Tell us about your environment

  • ESLint Version: 6.5.1
  • Node Version: 10.16.0
  • npm Version: 6.9.0

What parser (default, Babel-ESLint, etc.) are you using?

default

Please show your full configuration:

Configuration
module.exports = {
  parserOptions: {
    ecmaVersion: 2015,
  }
};

What did you do? Please include the actual source code causing the issue.

Online Demo Link 1

/* eslint operator-assignment: ["error", "always"]*/

x = /* comment */ x + y;

x = x // comment 
	+ y;

Online Demo Link 2

/* eslint operator-assignment: ["error", "never"]*/

x /* comment */ += y;

x // comment
	+= y;

What did you expect to happen?

Not to remove/duplicate comments.

What actually happened? Please include the actual, raw output from ESLint.

/* eslint operator-assignment: ["error", "always"]*/

x += y;

x += y;
/* eslint operator-assignment: ["error", "never"]*/

x /* comment */ = x /* comment */ + y;

x // comment
	= x // comment
	+ y;

What changes did you make? (Give an overview)

Check for the comments in the ranges there are going to be removed or copied to prevent fixing.

Is there anything you'd like reviewers to focus on?

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Oct 23, 2019
@mdjermanovic mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion autofix This change is related to ESLint's autofixing capabilities bug ESLint is working incorrectly rule Relates to ESLint's core rules and removed triage An ESLint team member will look at this issue soon labels Oct 23, 2019
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@btmills btmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@btmills btmills merged commit 1744fab into master Oct 25, 2019
@btmills btmills deleted the operatorassignment-comments branch October 25, 2019 18:07
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Apr 24, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Apr 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion autofix This change is related to ESLint's autofixing capabilities bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants