Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: no-trailing-spaces false negatives after comments (fixes #12479) #12480

Merged
merged 1 commit into from Oct 25, 2019

Conversation

mdjermanovic
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[X ] Bug fix #12479

This change produces more errors.

This PR fixes no-trailing-spaces to report trailing spaces after block comments when the ignoreComments option is set to true.

The option allows trailing spaces * in * comments, not after comments.

In addition to the example from #12479, the following are also false negatives (all lines with comments have trailing spaces):

/* eslint no-trailing-spaces: ["error", { ignoreComments: true }]*/ 

/* */     

/* */foo     

/* 
*/foo     

What changes did you make? (Give an overview)

Don't count the last line of a Block comment as a 'comment line' that should be ignored.

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic added bug ESLint is working incorrectly rule Relates to ESLint's core rules accepted There is consensus among the team that this change meets the criteria for inclusion labels Oct 22, 2019
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

Copy link
Member

@btmills btmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the thorough tests around this!

@btmills btmills merged commit c6a7745 into master Oct 25, 2019
@btmills btmills deleted the issue12479 branch October 25, 2019 18:10
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Apr 24, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Apr 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no-trailing-spaces doesn't report trailing spaces after block comments
3 participants