Update: fix uglified align in key-spacing (fixes #11414) #12472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-deprecated
bot
added
the
triage
yeonjuan
changed the title
kaicataldo
reviewed
Oct 24, 2019
kaicataldo
added
accepted
yeonjuan
changed the title
yeonjuan
changed the title
|
@kaicataldo I added more test cases for other options. thanks! |
kaicataldo
reviewed
Nov 1, 2019
aladdin-add
approved these changes
Nov 12, 2019
| beforeColon: false | ||
| }], | ||
| errors: [ | ||
| { messageId: "extraKey", data: { computed: "", key: "foo" }, line: 2, column: 5, type: "Identifier" }, |
There was a problem hiding this comment.
unrelated: it would be better to refactor the messageIds to "extraKey" || "extraComputedKey", rather than passing data: {"computed": ""}
|
So this change is producing this (IMHO unexpected) behavior: |
kaicataldo
added a commit
that referenced
this pull request
Nov 25, 2019
kaicataldo
added a commit
that referenced
this pull request
Nov 25, 2019
btmills
pushed a commit
that referenced
this pull request
Nov 25, 2019
This was referenced Mar 11, 2020
This was referenced Mar 26, 2020
This was referenced Apr 3, 2020
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Count properties on a line as a single line.
I think this PR can fix #11414
Is there anything you'd like reviewers to focus on?