Update: deprecate personal config (fixes #11914, refs eslint/rfcs#32) #12426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mysticatea
added
documentation
platinumazure
requested changes
Oct 28, 2019
Co-Authored-By: Kevin Partington <platinum.azure@kernelpanicstudios.com>
Co-Authored-By: Kevin Partington <platinum.azure@kernelpanicstudios.com>
|
Thank you for review. I have applied your suggestions. |
kaicataldo
reviewed
Nov 1, 2019
Co-Authored-By: Kai Cataldo <7041728+kaicataldo@users.noreply.github.com>
Co-Authored-By: Kai Cataldo <7041728+kaicataldo@users.noreply.github.com>
Co-Authored-By: Kai Cataldo <7041728+kaicataldo@users.noreply.github.com>
Co-Authored-By: Kai Cataldo <7041728+kaicataldo@users.noreply.github.com>
|
I have updated this PR to follow the review. |
|
@platinumazure Mind giving this one more look to confirm your concerns have been addressed? |
platinumazure
approved these changes
Nov 15, 2019
|
I apologize, I had forgotten about this one. Thanks @mysticatea and @kaicataldo for your patience! |
This was referenced Mar 11, 2020
This was referenced Mar 26, 2020
This was referenced Mar 30, 2020
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[X] Documentation update
[X] Other, please explain: deprecate a core feature
What changes did you make? (Give an overview)
This PR soft-deprecates the personal config file. This decision happened on RFC32 after RFC28's discussion. I removed the scattered descriptions about the personal config file then added those as the last section. Therefore, people can know what is deprecated clearly.
This is documentation-only change, but the label of this PR is
Update:because deprecation should be semver-minor.Is there anything you'd like reviewers to focus on?
Nothing in particular.