Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: remove default overrides in keyword-spacing (fixes #12369) #12411

Merged
merged 2 commits into from Oct 18, 2019
Merged

Update: remove default overrides in keyword-spacing (fixes #12369) #12411

merged 2 commits into from Oct 18, 2019

Conversation

yeonjuan
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[X] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)
Remove default property in overrides scheme
I found that the overrides scheme's default value override the undeclared overrides option's value

Is there anything you'd like reviewers to focus on?
fix #12369,

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Oct 12, 2019
@yeonjuan yeonjuan mentioned this pull request Oct 17, 2019
Closed
platinumazure
platinumazure approved these changes Oct 17, 2019
View reviewed changes
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but I'd like to get another set of eyes on this before merging. Thanks for contributing!

@platinumazure platinumazure added accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly rule Relates to ESLint's core rules and removed triage An ESLint team member will look at this issue soon labels Oct 17, 2019
mdjermanovic
mdjermanovic requested changes Oct 17, 2019
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! It would be good to have the name of this rule in the PR title.

tests/lib/rules/keyword-spacing.js Show resolved Hide resolved
@yeonjuan yeonjuan changed the title Update: remove default property in override scheme (fixes #12369) Update: remove default value in keyword-spacing override schemes (fixes #12369) Oct 18, 2019
@yeonjuan yeonjuan changed the title Update: remove default value in keyword-spacing override schemes (fixes #12369) Update: remove default override in keyword-spacing (fixes #12369) Oct 18, 2019
@yeonjuan yeonjuan changed the title Update: remove default override in keyword-spacing (fixes #12369) Update: remove default overrides in keyword-spacing (fixes #12369) Oct 18, 2019
mdjermanovic
mdjermanovic approved these changes Oct 18, 2019
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@platinumazure platinumazure merged commit 84f71de into eslint:master Oct 18, 2019
This was referenced Nov 9, 2019
Open
Open
@snyk-bot snyk-bot mentioned this pull request Nov 21, 2019
Merged
@snyk-bot snyk-bot mentioned this pull request Dec 1, 2019
Merged
@snyk-bot snyk-bot mentioned this pull request Feb 13, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Feb 27, 2020
Merged
@a-martynovich a-martynovich mentioned this pull request Mar 10, 2020
Merged
This was referenced Mar 11, 2020
Merged
Open
This was referenced Mar 26, 2020
Merged
Merged
Merged
Open
@snyk-bot snyk-bot mentioned this pull request Apr 3, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 4, 2020
Merged
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Apr 17, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@platinumazure platinumazure platinumazure approved these changes

@mdjermanovic mdjermanovic mdjermanovic approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

keyword-spacing else ghost default
3 participants
@yeonjuan @platinumazure @mdjermanovic