Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fixes object type for rules in "Use a Plugin" #12409

Merged
merged 1 commit into from Oct 13, 2019
Merged

Docs: Fixes object type for rules in "Use a Plugin" #12409

merged 1 commit into from Oct 13, 2019

Conversation

daisy-develops
Copy link
Contributor

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)
This patch updates the Use a Plugin example which has rules listed as an array instead of a regular object.

Is there anything you'd like reviewers to focus on?
This is a very small change because I just happened to notice it while trying to learn how to use eslint 馃樃

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Oct 12, 2019
@g-plane g-plane added documentation Relates to ESLint's documentation and removed triage An ESLint team member will look at this issue soon labels Oct 12, 2019
Copy link
Member

@g-plane g-plane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@g-plane g-plane changed the title Fixes object type for rules in "Use a Plugin" Docs: Fixes object type for rules in "Use a Plugin" Oct 12, 2019
@daisy-develops
Copy link
Contributor Author

Hmm, I thought I did a good job, should I amend/force the original commit to add "Docs: ..." to the summary?

@g-plane
Copy link
Member

g-plane commented Oct 13, 2019

It will be better to do that.

@ilyavolodin
Copy link
Member

Thanks for contribution!

@ilyavolodin ilyavolodin merged commit 97045ae into eslint:master Oct 13, 2019
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Apr 12, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants