Update: Regex incorrectly checks newline in comments (fixes #12263)

[yeonjuan]

What is the purpose of this pull request? (put an "X" next to item)

[X] Bug fix (#12263)

What changes did you make? (Give an overview)
Fix regex in sourceCode.isSpaceBetweenTokens()

Is there anything you'd like reviewers to focus on?
#12263

[jsf-clabot]

All committers have signed the CLA.

[kaicataldo]

Thanks for working on this!

[kaicataldo]

LGTM, thanks!

[mdjermanovic]

The change LGTM, but I think that the commit message and PR title should be Update: because this is a bug fix that can produce more warnings.

At the moment It's probably only a few core rules where that could happen.

Example:

/* eslint space-before-function-paren:["error", "always"]*/

function foo/* comment
*/(){}

function foo// comment
(){}

This can also affect plugins.

Might be also good to somehow check will the flag be transpiled for the online demo, because it isn't widely supported in browsers yet.

[platinumazure]

Looks good! I agree with @mdjermanovic, this should be an Update as this can add more lint messages in some cases.

Could you please edit the PR title to use the "Update:" prefix? Thanks!

[yeonjuan]

@platinumazure Ok! That make sense! Thanks!

[platinumazure]

Looks good. Thanks for changing the commit summary!

We can leave this open another day or two in case more teammates want to review this.

[mdjermanovic]

LGTM, thanks!

@platinumazure the commit message is still Fix:, maybe to leave it as is and change the message while merging the PR?

[platinumazure]

@platinumazure the commit message is still Fix:, maybe to leave it as is and change the message while merging the PR?

@mdjermanovic On the GitHub interface, the default/suggested merge commit message is the PR title if there are two or more commits. So if we merge using GitHub, it will suggest the PR title in this case. That's why the "commit-message" status check is currently passing and nothing needs to be done here.

(When there is only one commit, that commit's message is suggested/used, so in that case, we would need to edit it on merge.)