Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix minor formatting/grammar errors #12371

Merged
merged 7 commits into from Oct 4, 2019
Merged

Docs: Fix minor formatting/grammar errors #12371

merged 7 commits into from Oct 4, 2019

Conversation

cherryblossom000
Copy link
Contributor

What is the purpose of this pull request? (put an "X" next to item)

  • Documentation update
  • Bug fix (template)
  • New rule (template)
  • Changes an existing rule (template)
  • Add autofixing to a rule
  • Add a CLI option
  • Add something to the core
  • Other, please explain:

What changes did you make? (Give an overview)

  • Fixed link to code conventions from the pull requests doc
  • "[[Call]]" => "[[Call]]" in no-obj-calls doc
  • Object literal spacing in example config in space-infix-ops
  • "may have optional description" => "may have an optional description" in symbol-description

Is there anything you'd like reviewers to focus on?

No.

All other example configs in the docs spaced curly braces in object literals, so this commit updates this for consistency.
@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Oct 4, 2019
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!

docs/developer-guide/contributing/pull-requests.md Outdated Show resolved Hide resolved
@kaicataldo kaicataldo added documentation Relates to ESLint's documentation and removed triage An ESLint team member will look at this issue soon labels Oct 4, 2019
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for contributing!

@kaicataldo kaicataldo merged commit 3642342 into eslint:master Oct 4, 2019
@cherryblossom000 cherryblossom000 deleted the docs-errors branch October 4, 2019 23:50
captbaritone pushed a commit to captbaritone/eslint that referenced this pull request Oct 5, 2019
* Docs: Fix link to code conventions

* Docs: Fix formattting

* Docs: Fix formatting of example config

All other example configs in the docs spaced curly braces in object literals, so this commit updates this for consistency.

* Docs: Fixed grammar

* Docs: Revert link to code conventions

This reverts commit ab5dba7.

* Docs: Revert link to code conventions

* Docs: Revert link to code conventions

Sorry for all the commits.
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Apr 3, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants