New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: no-useless-rename handles ExperimentalRestProperty (fixes #12335) #12339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-deprecated
bot
added
the
triage
An ESLint team member will look at this issue soon
label
Sep 29, 2019
kaicataldo
added
accepted
There is consensus among the team that this change meets the criteria for inclusion
bug
ESLint is working incorrectly
patch candidate
This issue may necessitate a patch release in the next few days
rule
Relates to ESLint's core rules
and removed
triage
An ESLint team member will look at this issue soon
labels
Sep 29, 2019
kaicataldo
force-pushed
the
fix-12335
branch
from
September 29, 2019 16:20
dada624
to
3c2083b
Compare
platinumazure
approved these changes
Sep 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
ljharb
approved these changes
Sep 29, 2019
mysticatea
approved these changes
Sep 30, 2019
g-plane
approved these changes
Sep 30, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
This was referenced Oct 9, 2019
This was referenced Oct 22, 2019
This was referenced Nov 9, 2019
This was referenced Mar 11, 2020
This was referenced Mar 26, 2020
eslint-deprecated
bot
added
the
archived due to age
This issue has been archived; please open a new issue for any further discussion
label
Mar 31, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
accepted
There is consensus among the team that this change meets the criteria for inclusion
archived due to age
This issue has been archived; please open a new issue for any further discussion
bug
ESLint is working incorrectly
patch candidate
This issue may necessitate a patch release in the next few days
rule
Relates to ESLint's core rules
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
fixes #12335
What changes did you make? (Give an overview)
#12322 removed the check for
ExperimentalRestProperty
, causing the rule to crash with babel-eslint. This will be fixed by babel/babel-eslint#785 on the babel-eslint side.Is there anything you'd like reviewers to focus on?
Nothing in particular!