Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: add autofix npm script #12330

Merged
merged 1 commit into from Sep 29, 2019
Merged

Chore: add autofix npm script #12330

merged 1 commit into from Sep 29, 2019

Conversation

kaicataldo
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

What changes did you make? (Give an overview)
This adds a fix flag to the lint task in Makefile.js and adds a fix npm script as a small convenience for contributors.

Is there anything you'd like reviewers to focus on?
Nothing in particular!

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Sep 28, 2019
@kaicataldo kaicataldo added chore This change is not user-facing and removed triage An ESLint team member will look at this issue soon labels Sep 28, 2019
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Probably overthinking this, but: Should we handle differently in case this is called from CI? (It shouldn't be, but...)

@kaicataldo
Copy link
Member Author

@platinumazure Mind elaborating on what you mean? Not sure I understand. Thanks!

@platinumazure
Copy link
Member

I was just wondering if we wanted to have an environment variable check in that task, where if the task was called from CI, then it should throw an error.

As I type this, I'm thinking not, so go ahead and just ignore what I said.

Copy link
Member

@mysticatea mysticatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@mysticatea mysticatea merged commit 160b7c4 into master Sep 29, 2019
@mysticatea mysticatea deleted the add-fix-script branch September 29, 2019 03:21
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Mar 29, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants