Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: 1tbs with allowSingleLine edge cases (refs #12284) #12314

Merged
merged 1 commit into from Dec 14, 2019

Conversation

kardasis
Copy link
Contributor

@kardasis kardasis commented Sep 26, 2019

add documentation and tests demonstrating iffy edge cases

What is the purpose of this pull request? (put an "X" next to item)

[ x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x ] Other, please explain: Additional tests

What changes did you make? (Give an overview)
Added tests and documentation for 1tbs with allowSingleLine

Is there anything you'd like reviewers to focus on?
Looking for some feedback about whether these examples are desirable

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Sep 26, 2019
@kardasis kardasis changed the title docs: (ref #12284) Docs: 1tbs with allowSingleLine edge cases (ref #12284) Sep 26, 2019
Add documentation and tests demonstrating iffy edge cases
@kardasis kardasis changed the title Docs: 1tbs with allowSingleLine edge cases (ref #12284) Docs: 1tbs with allowSingleLine edge cases (refs #12284) Sep 26, 2019
@kaicataldo kaicataldo added documentation Relates to ESLint's documentation evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion rule Relates to ESLint's core rules and removed triage An ESLint team member will look at this issue soon labels Sep 26, 2019
@kaicataldo
Copy link
Member

Thanks for doing this - this is a great way to evaluate this behavior!

Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. Agreed that some of these cases are a bit strange, but I think we should merge this as-is since it better documents the current behavior.

@kaicataldo kaicataldo added accepted There is consensus among the team that this change meets the criteria for inclusion chore This change is not user-facing and removed evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Dec 14, 2019
@kaicataldo
Copy link
Member

Apologies for the delay. Thanks for the contributing!

@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Jun 13, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jun 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing documentation Relates to ESLint's documentation rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants