New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: no-undef-init autofix removes comments #12299
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Hmmm, looks like we have a flaky test (not necessarily related to this change) in the test suite. |
Looks like https://github.com/eslint/eslint/pull/12290/checks?check_run_id=228384386 is failing in the same environment (though it looks like it timed out in the install rather than the test run phase). |
Could be a problem with |
Yeah, seems likely it's an issue with GitHub Hooks. I don't think we need to hold up either PR for this, especially since it's passing in Azure Pipelines in macOS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
What is the purpose of this pull request? (put an "X" next to item)
[X] Bug fix
Tell us about your environment
What parser (default, Babel-ESLint, etc.) are you using?
default
Please show your full configuration:
Configuration
What did you do? Please include the actual source code causing the issue.
Demo link
What did you expect to happen?
2 errors, but not to remove comments.
What actually happened? Please include the actual, raw output from ESLint.
What changes did you make? (Give an overview)
Report errors but don't fix if that would remove any comments.
Is there anything you'd like reviewers to focus on?