update globals to v12.1.0 #12296
Merged
update globals to v12.1.0 #12296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
eslint-deprecated
bot
added
the
triage
kaicataldo
added
evaluating
|
sindresorhus/globals#143 looks like the only change that would affect existing globals. It looks like it'll lead to fewer errors, though, so I think it's fine to release this as a semver-minor bug fix. |
kaicataldo
added
the
enhancement
|
Is there anything blocking this? |
|
No, sorry, we lost track of this PR. Thanks for the reminder. We are currently in merge freeze due to possibility of patch release, but once we are out of it, we'll merge this in. |
ilyavolodin
approved these changes
Oct 27, 2019
ilyavolodin
added
accepted
This was referenced Mar 11, 2020
This was referenced Mar 26, 2020
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:
Update dependency
What changes did you make? (Give an overview)
Update
globalsdependency to v12.1.0 Here are the changesMost notably for me is the addition of globals to the
jasmineenvironment:expectAsyncandspyOnAllFunctionsIs there anything you'd like reviewers to focus on?
No