Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add supported ECMAScript version to README #12290

Merged
merged 1 commit into from Sep 29, 2019
Merged

Conversation

mdjermanovic
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[X] Documentation update

What changes did you make? (Give an overview)

Added 2019 in the README as a fully supported version.

Is there anything you'd like reviewers to focus on?

Since the sentence is 'has full support' I guess it's too early to add 2020 as well?

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Sep 19, 2019
@mdjermanovic mdjermanovic added documentation Relates to ESLint's documentation and removed triage An ESLint team member will look at this issue soon labels Sep 19, 2019
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change LGTM. (Good question about ES2020, but I think this could be merged safely and it would be an improvement.)

@kaicataldo
Copy link
Member

As commented here, I don't think we need to hold up this PR for the flaky macOS GitHub Hook.

@platinumazure platinumazure merged commit c9aeab2 into master Sep 29, 2019
@platinumazure platinumazure deleted the docs-readme2019 branch September 29, 2019 03:15
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Mar 29, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants