sourceCode.isSpaceBetweenTokens() and multiline comments

[mdjermanovic]

Noticed this while working on #12259

sourceCode.isSpaceBetweenTokens() sees newlines inside multiline block comments as spaces.

Observable:

/* eslint space-before-function-paren:["error", "never"]*/

function foo/*
*/(){}

Demo link

The above is an error because of the newline (function foo/* */(){} is not an error for the same rule.)

Is it intentional or a bug?

There is no such test for isSpaceBetweenTokens() in source-code tests.

Also, when I add the s flag to the /\/\*.*?\*\//gu regex in isSpaceBetweenTokens and run npm test everything still works.

[kaicataldo]

Seems like a bug to me.

[mysticatea]

Sounds a bug to me.

Maybe, the function has been used to check two tokens which are on the same line in most cases. Because spacing rules do nothing if two tokens are on different lines in general.

[kaicataldo]

I will try to work on this this weekend!

[kaicataldo]

@mdjermanovic Though if you need to fix it for your work, please feel free to take it on. I don’t want to block you!

[mdjermanovic]

@kaicataldo Feel free to claim this :)

The effects of this change can be also observed in the current version of template-tag-spacing, it will have more and fewer errors in some cases.

[kaicataldo]

Sorry I haven't gotten to this yet. It's in my backlog, but if someone can get to it before I can, please feel free!

[mdjermanovic]

Fixed in #12407