Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New: add no-import-assign (fixes #12237) #12252

Merged
merged 6 commits into from Sep 14, 2019
Merged

New: add no-import-assign (fixes #12237) #12252

merged 6 commits into from Sep 14, 2019

Conversation

mysticatea
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[X] New rule: fixes #12237.

What changes did you make? (Give an overview)

This PR adds a new rule no-import-assign.

Is there anything you'd like reviewers to focus on?

  • Is documentation enough?
  • Are tests enough?

@mysticatea mysticatea added rule Relates to ESLint's core rules accepted There is consensus among the team that this change meets the criteria for inclusion feature This change adds a new feature to ESLint labels Sep 10, 2019
@mysticatea
Copy link
Member Author

I have updated this rule to follow the review!

tests/lib/rules/no-import-assign.js Show resolved Hide resolved
tests/lib/rules/no-import-assign.js Outdated Show resolved Hide resolved
tests/lib/rules/no-import-assign.js Outdated Show resolved Hide resolved
tests/lib/rules/no-import-assign.js Outdated Show resolved Hide resolved
@mysticatea
Copy link
Member Author

I have updated this rule to follow the review!

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Maybe just one more import mod, * as mod_ns from 'mod' test that mutates both, but errors only mod_ns

@ilyavolodin ilyavolodin merged commit 1c921c6 into master Sep 14, 2019
@ilyavolodin ilyavolodin deleted the issue12237 branch September 14, 2019 00:30
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Mar 13, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Mar 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion feature This change adds a new feature to ESLint rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rule Proposal: disallow the updates of imported bindings
4 participants