Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: enable default-param-last #12244

Merged

Conversation

aladdin-add
Copy link
Member

note: this is a breaking change in eslint-config-eslint.

refs:0313441

What is the purpose of this pull request? (put an "X" next to item)

[x] Other, please explain: just dog fooding the new rule. :-)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?
not really.

@aladdin-add aladdin-add added evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion chore This change is not user-facing labels Sep 8, 2019
note: this is a breaking change in eslint-config-eslint.

refs:eslint@0313441
@aladdin-add aladdin-add force-pushed the chore/enable-default-param-last branch from 2807290 to cb84207 Compare September 8, 2019 14:57
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aladdin-add aladdin-add merged commit f9fc695 into eslint:master Sep 14, 2019
@aladdin-add aladdin-add deleted the chore/enable-default-param-last branch September 14, 2019 10:52
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Mar 13, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Mar 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants