New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: fix no-sequences with
examples
#12239
Conversation
Actually I understand now why the |
Done. All lines are still there, the example in question is just uncommented. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
What is the purpose of this pull request? (put an "X" next to item)
[X] Documentation update
There is an unusual commented
// with
example in no-sequences documentation.It could have something with linting documentation examples (#2271) in the past?
What changes did you make? (Give an overview)
Removed both
with
examples from this document.The example can be uncommented now and
npm test
will work well. Nevertheless, I think thatwith
is not of particular importance for this rule, there are no examples withwith
in other rules (apart from how to disable it inno-with
andno-restricted-syntax
) so I guess it's better to avoid it in examples?Is there anything you'd like reviewers to focus on?
If it isn't okay to remove these lines, I'll revert it and just uncomment the example.