Fix: yoda rule produces invalid autofix with preceding yield

[mdjermanovic]

What is the purpose of this pull request? (put an "X" next to item)

[X] Bug fix

Tell us about your environment

• ESLint Version: 6.2.2
• Node Version: 10.16.0
• npm Version: 6.9.0

What parser (default, Babel-ESLint, etc.) are you using?

default

Please show your full configuration:

Configuration

module.exports = {
  parserOptions: {
    ecmaVersion: 2015,
  },
};

What did you do? Please include the actual source code causing the issue.

Demo link 1

/*eslint yoda: ["error", "never"]*/

function *foo() {
  yield(1) < a;
}

Demo link 2

/*eslint yoda: ["error", "always"]*/

function *foo() {
  yield++a < 1;
}

What did you expect to happen?

Fix to:

/*eslint yoda: ["error", "never"]*/

function *foo() {
  yield a > (1);
}

/*eslint yoda: ["error", "always"]*/

function *foo() {
  yield 1 > ++a;
}

What actually happened? Please include the actual, raw output from ESLint.

Fixed to:

/*eslint yoda: ["error", "never"]*/

function *foo() {
  yielda > (1);
}

/*eslint yoda: ["error", "always"]*/

function *foo() {
  yield1 > ++a;
}

What changes did you make? (Give an overview)

Fixed the fixer to check can the tokens be adjacent.

Is there anything you'd like reviewers to focus on?

Only these tests were failing, others are regression tests:

function *foo() { yield(1) < a }
function *foo() { yield((1)) < a }
function *foo() { yield++a < 1 }
function *foo() { yield(a) < 1 }

[platinumazure]

LGTM, thanks!

[btmills]

LGTM, thanks!

[kaicataldo]

Thanks for contributing!