Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Fix wrong error object keys in test files #12162

Merged
merged 1 commit into from Aug 26, 2019
Merged

Conversation

mdjermanovic
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[X] Other, please explain:

What changes did you make? (Give an overview)

Fixed test cases that had nodeType instead of type and various typos like messgeId in 6 files.

Is there anything you'd like reviewers to focus on?

no-extra-parens tests are fixed in #12142. Other test files are OK in regard to this.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Aug 25, 2019
@mdjermanovic mdjermanovic added the chore This change is not user-facing label Aug 25, 2019
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@platinumazure platinumazure added accepted There is consensus among the team that this change meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Aug 25, 2019
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing this!

@kaicataldo kaicataldo merged commit 31e5428 into master Aug 26, 2019
@kaicataldo
Copy link
Member

Thanks for contributing to ESLint!

@platinumazure platinumazure deleted the test-typos branch August 26, 2019 18:13
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 23, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants