Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New: reportUnusedDisableDirectives in config (refs eslint/rfcs#22) #12151

Merged
merged 1 commit into from Aug 30, 2019
Merged

New: reportUnusedDisableDirectives in config (refs eslint/rfcs#22) #12151

merged 1 commit into from Aug 30, 2019

Conversation

mysticatea
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[X] Add something to the core

What changes did you make? (Give an overview)

This PR adds reportUnusedDisableDirectives top-level property support to config files. This feature has been approved in eslint/rfcs#22.

Is there anything you'd like reviewers to focus on?

Nothing in particular.

@mysticatea mysticatea added core Relates to ESLint's core APIs and features accepted There is consensus among the team that this change meets the criteria for inclusion feature This change adds a new feature to ESLint labels Aug 23, 2019
@mysticatea mysticatea mentioned this pull request Aug 24, 2019
Merged
platinumazure
platinumazure approved these changes Aug 30, 2019
View reviewed changes
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

kaicataldo
kaicataldo approved these changes Aug 30, 2019
View reviewed changes
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

btmills
btmills approved these changes Aug 30, 2019
View reviewed changes
Copy link
Member

@btmills btmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whew, nice work piping this through @mysticatea! LGTM

@btmills btmills merged commit 52e2cf5 into master Aug 30, 2019
@mysticatea mysticatea deleted the report-unused-disable-directives branch August 31, 2019 08:53
This was referenced Sep 9, 2019
Merged
Merged
Merged
Merged
This was referenced Sep 24, 2019
Merged
Closed
@snyk-bot snyk-bot mentioned this pull request Oct 13, 2019
Closed
This was referenced Oct 22, 2019
Merged
Open
This was referenced Nov 9, 2019
Open
Open
@snyk-bot snyk-bot mentioned this pull request Nov 21, 2019
Merged
@snyk-bot snyk-bot mentioned this pull request Feb 27, 2020
Merged
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 27, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@platinumazure platinumazure platinumazure approved these changes

@btmills btmills btmills approved these changes

@kaicataldo kaicataldo kaicataldo approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion core Relates to ESLint's core APIs and features feature This change adds a new feature to ESLint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mysticatea @platinumazure @btmills @kaicataldo