Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fix message of function-paren-newline (fixes #12134) #12136

Merged
merged 1 commit into from Aug 26, 2019

Conversation

g-plane
Copy link
Member

@g-plane g-plane commented Aug 21, 2019

What is the purpose of this pull request? (put an "X" next to item)

[x] Bug fix

What changes did you make? (Give an overview)
Fixes #12134 .

Is there anything you'd like reviewers to focus on?
These changes only affect message content, but this rule uses messageId, and I think there's no need to add or update tests.

@g-plane g-plane added bug ESLint is working incorrectly rule Relates to ESLint's core rules accepted There is consensus among the team that this change meets the criteria for inclusion labels Aug 21, 2019
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for contributing to ESLint!

@kaicataldo kaicataldo merged commit a81d263 into master Aug 26, 2019
@kaicataldo
Copy link
Member

Thanks for contributing to ESLint!

@g-plane g-plane deleted the issue-12134 branch August 27, 2019 00:31
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 23, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

function-paren-newline reports wrong messages
3 participants