Fix: func-name-matching crash on descriptor-like arguments

[mdjermanovic]

What is the purpose of this pull request? (put an "X" next to item)

[X] Bug fix

Tell us about your environment

• ESLint Version: 6.1.0
• Node Version: 10.16.0
• npm Version: 6.9.0

What parser (default, Babel-ESLint, etc.) are you using?

default

Please show your full configuration:

Configuration

module.exports = {
  parserOptions: {
    ecmaVersion: 2015,
  },
};

What did you do? Please include the actual source code causing the issue.

/*eslint func-name-matching: ["error", { "considerPropertyDescriptor": true }]*/

foo({ value: function bar() {} })

What did you expect to happen?

Not to crash.

What actually happened? Please include the actual, raw output from ESLint.

TypeError: Cannot read property 'name' of undefined

What changes did you make? (Give an overview)

Fixed the bug.

Is there anything you'd like reviewers to focus on?

There is still a number of places where the rule can crash or produce false positives on a designed example, as the code doesn't check parent types, correct index of the child in parent's arguments, existence and types of other arguments from which it reads etc.

The example which is fixed in this PR can easily occur in a real code, so it might make sense to fix just this at the moment.

For the rest, I believe it would be better to make helpers in astUtils as there are at least 3 other rules that also work with descriptors and have a very similar code (and some small bugs as well).

[g-plane]

I can reproduce it on demo.

[g-plane]

LGTM, thanks!

[kaicataldo]

LGTM. Thanks!

[platinumazure]

LGTM, thanks!

[kaicataldo]

Thanks for contributing to ESLint!