New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report '\08' and '\09' in no-octal-escape #12080
Report '\08' and '\09' in no-octal-escape #12080
Comments
Unfortunately, it looks like there wasn't enough interest from the team Thanks for contributing to ESLint and we appreciate your understanding. |
Reopening because it's probably a false negative. |
Marking this as accepted since it's a bug report with three 👍s |
Looks like no one is working on this, so I'll take it. |
Tell us about your environment
What parser (default, Babel-ESLint, etc.) are you using?
default
Please show your full configuration:
Configuration
What did you do? Please include the actual source code causing the issue, as well as the command that you used to run ESLint.
What did you expect to happen?
2 errors
What actually happened? Please include the actual, raw output from ESLint.
No errors
Are you willing to submit a pull request to fix this bug?
Yes, I'll be glad to do it. (#12079 should be merged first as this would collide)
Engines/parsers are already reporting these as octal escapes in strict mode:
Octal escape sequences are not allowed in strict mode.
"0"-prefixed octal literals and octal escape sequences are deprecated; for octal literals use the "0o" prefix instead
Octal literal in strict mode
Per the spec.
08
is not a valid escape sequence but it seems that it can be interpreted like0
as a LegacyOctalEscapeSequence followed by a character8
.So I guess to be technically correct the rule should report
\0
?The text was updated successfully, but these errors were encountered: