Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Remove TDZ scope from the scope manager interface documentation #12054

Merged
merged 1 commit into from Aug 13, 2019
Merged

Docs: Remove TDZ scope from the scope manager interface documentation #12054

merged 1 commit into from Aug 13, 2019

Conversation

mdjermanovic
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[X] Documentation update

What changes did you make? (Give an overview)

Removed TDZ Scope type and TDZ Definition type from scope-manager-interface.md

Is there anything you'd like reviewers to focus on?

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Aug 2, 2019
@platinumazure
Copy link
Member

platinumazure commented Aug 3, 2019

Hi @mdjermanovic, thanks for the PR.

Could I have some background on this please? Did we ever have TDZ scope? Did we remove it at some point? Thanks!

@mysticatea
Copy link
Member

It happened in 5.0.0: #10245

We had TDZScope class for some reason, but I removed it because TDZ is timing matter.

Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion triage An ESLint team member will look at this issue soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants