New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
key/property rules and ObjectPattern #12048
Comments
Unfortunately, it looks like there wasn't enough interest from the team Thanks for contributing to ESLint and we appreciate your understanding. |
I think we'll need to evaluate each of these rules separately. It seems like all these rules should apply to this syntax, but they should probably be individually configurable.
Example code: const foo = { a: 'b' };
const { 'a': bar } = foo;
const { ['a']: baz } = foo; |
Unfortunately, it looks like there wasn't enough interest from the team Thanks for contributing to ESLint and we appreciate your understanding. |
@mdjermanovic what do you want to do with this issue? |
@mdjermanovic do you want to finish this issue up? |
Yes, I'll check Docs and tests for
|
Tell us about your environment
What parser (default, Babel-ESLint, etc.) are you using?
default
Please show your full configuration:
Configuration
What did you do? Please include the actual source code causing the issue.
There are 4 rules that report
ObjectPattern
properties, it's probably a bug because there are no examples in the documentation and there are no test cases.What did you expect to happen?
No warnings.
What actually happened? Please include the actual, raw output from ESLint.
4 warnings, one for each of the rules.
Are you willing to submit a pull request to fix this bug?
Yes, for whatever is decided.
quote-props
andkey-spacing
are not working well at the moment (see PRs #12046 and #12047), I guess these fixes should be applied to skipObjectPattern
for now. A possible enhancements could be to add options later.no-useless-computed-key
andcomputed-property-spacing
might work well already. Possible actions could be:ObjectPattern
.The text was updated successfully, but these errors were encountered: