New: function-call-argument-newline rule (fixes #10323) #12024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-deprecated
bot
added
the
triage
platinumazure
added
accepted
platinumazure
changed the title
platinumazure
approved these changes
Jul 27, 2019
There was a problem hiding this comment.
Hi @finico, thanks for the PR!
This looks good to me at a glance, but I would like to give other team members a chance to review. Thanks for contributing!
kaicataldo
approved these changes
Jul 27, 2019
|
Re indentation in fixers: since we have a multi-pass autofix system, we try to keep fixes to the minimum changes necessary and let other rules handle autofixing things they warn about. The indentation rule would fix this, so this is correct 👍. |
|
Merged. Thanks for contributing! Sorry for the delay in getting this in. |
This was referenced Aug 27, 2019
This was referenced Sep 12, 2019
This was referenced Nov 9, 2019
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix (template)
[x] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What category of rule is this? (place an "X" next to just one item)
[x] Enforces code style
[ ] Warns about a potential error
[ ] Suggests an alternate way of doing something
[ ] Other (please specify:)
What changes did you make? (Give an overview)
All information about this rule in #10323
Is there anything you'd like reviewers to focus on?
I didn't add indentations in fixers. But I've checked other rules and they don't do it as well..