Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade: Upgrade lodash dependency (fixes #11992) #11994

Merged
merged 1 commit into from Jul 16, 2019

Conversation

quetzaluz
Copy link
Contributor

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[X] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain:

  • Dependency upgrade / security fix

What changes did you make? (Give an overview)

  • Dependency upgrade

Is there anything you'd like reviewers to focus on?

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Jul 15, 2019
@jsf-clabot
Copy link

jsf-clabot commented Jul 15, 2019

CLA assistant check
All committers have signed the CLA.

@quetzaluz quetzaluz force-pushed the upgrade-lodash-fix-11992 branch 2 times, most recently from bb3a140 to 758f99e Compare July 15, 2019 23:11
@quetzaluz quetzaluz changed the title Fix #11992 - Upgrade lodash dependency per lodash/lodash#4348 Chore: Upgrade lodash dependency lodash/lodash#4348 (fixes #11992) Jul 15, 2019
Issue in lodash filed at lodash/lodash#4348
@quetzaluz quetzaluz changed the title Chore: Upgrade lodash dependency lodash/lodash#4348 (fixes #11992) Upgrade: Upgrade lodash dependency (fixes #11992) Jul 15, 2019
@g-plane g-plane added chore This change is not user-facing and removed triage An ESLint team member will look at this issue soon labels Jul 16, 2019
Copy link
Member

@g-plane g-plane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@shailesh-kanzariya
Copy link

Thanks @quetzaluz for the fix #11992. Any idea, when this change will be available to master?

Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants