New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: glob processing (fixes #11940) #11986
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but would like more eyes on this change. Thanks!
OK. I updated this PR to follow @aladdin-add 's suggestion.
|
just to clarify: if the user quotes like |
@aladdin-add Yes. |
What is the purpose of this pull request? (put an "X" next to item)
[X] Bug fix: #11940
What changes did you make? (Give an overview)
This PR fixes glob processing to iterate target files. The new way is similar to how shell passes globs to programs. I.e., if there are files that the glob matched, it adopts the matched files. Otherwise, it adopts the glob string as is.
Is there anything you'd like reviewers to focus on?
Nothing in particular.