Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: glob processing (fixes #11940) #11986

Merged
merged 3 commits into from Jul 21, 2019
Merged

Fix: glob processing (fixes #11940) #11986

merged 3 commits into from Jul 21, 2019

Conversation

mysticatea
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[X] Bug fix: #11940

What changes did you make? (Give an overview)

This PR fixes glob processing to iterate target files. The new way is similar to how shell passes globs to programs. I.e., if there are files that the glob matched, it adopts the matched files. Otherwise, it adopts the glob string as is.

Is there anything you'd like reviewers to focus on?

Nothing in particular.

@mysticatea mysticatea added bug ESLint is working incorrectly core Relates to ESLint's core APIs and features accepted There is consensus among the team that this change meets the criteria for inclusion labels Jul 14, 2019
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but would like more eyes on this change. Thanks!

@mysticatea
Copy link
Member Author

mysticatea commented Jul 18, 2019

OK. I updated this PR to follow @aladdin-add 's suggestion.

eslint [ab].js-like commands have different behaviors between Windows and the others, it will be no problem because those are enough rare cases.

@aladdin-add
Copy link
Member

just to clarify: if the user quotes like eslint "[ab].js", will have the same behavior between Windows and the others. am I reading correctly?

@mysticatea
Copy link
Member Author

@aladdin-add Yes. eslint "[ab].js" has the same behavior on all platforms.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly core Relates to ESLint's core APIs and features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't lint files with square brackets in the name
3 participants