Eslint broke plugin resolution from 5 version

[Delagen]

Tell us about your environment

• ESLint Version: 6.0
• Node Version: 12.4.0
• npm Version: 6.9.0

What parser (default, Babel-ESLint, etc.) are you using? @typescript-eslint/parser

Please show your full configuration:

Configuration

...
"plugins": [
		"node"
	],
...

What did you do? Please include the actual source code causing the issue, as well as the command that you used to run ESLint.

I have shared package which contains all the dependencies (plugins) and call eslint parser via CLIEngine

const linter = new CLIEngine(options);

invoked via runner

What did you expect to happen?
All works as expected

What actually happened? Please include the actual, raw output from ESLint.

Failed to load eslint-plugin-node
https://github.com/eslint/eslint/blob/master/lib/cli-engine/config-array-factory.js#L870

Cause it contained in subpackage that calling this code? I think in broke many shared runners.

[mysticatea]

Hi. How do you run eslint?

As the migration guide says, we have changed plugin resolution intentionally. Is this not related to your case?

[Delagen]

I resolved this via resolvePluginsRelativeTo option of CLIEngine.
But now has error Configured parser 'full path to @typescript-eslint\parser\dist\p
arser.js' was not found.

I called it from my shared package via Node.JS api.

main-package
|--node_modules
|     |--sharedPackage
|     |     |--node_modules
|     |     |     |--eslint
|     |     |     |--eslint-plugin....
|     |     |     |--@typescript-eslint/parser

[mysticatea]

If it's an absolute path and the file existed, it should load successfully. Would you confirm the path is valid and exists?

[Delagen]

Yes, path is valid and file exists. Tried to update parser to canary version, but no success

[mysticatea]

Would you check the version of your @typescript-eslint/parser? 1.11.0 got supported ESLint 6.

[mysticatea]

Ah, sorry. You said canary.

Hmm. I'm not sure what it happened. If you provided a repro case, it will be helpful.

[Delagen]

https://github.com/Delagen/eslint-resolution-issue

npm run test

[mysticatea]

Ah, I see. Thank you for the repro repo!

This is related to Linter no longer tries to load missing parsers from the filesystem section. Linter class doesn't load parsers automatically. I'd like to recommend to use CLIEngine instead of Linter.

[Delagen]

Thanks. Rewrote code to executeOnText of CLIEngine.
Any way to remove check rule for existense in disable comments?

[mysticatea]

Unfortunately, there are no ways. Since #11742, ESLint validates directive comments stricter.

[Delagen]

I use multi pass eslint with different configs and plugins. One for all js, second for client code with angular plugin, and etc. So common pass fail when found directive from specific plugin. Temporary silenced this error with filter by message text.

[mysticatea]

Closing as answered. Thank you.