Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: improve error message on --print-config (fixes #11874) #11885

Merged
merged 2 commits into from Jun 25, 2019
Merged

Fix: improve error message on --print-config (fixes #11874) #11885

merged 2 commits into from Jun 25, 2019

Conversation

mysticatea
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[X] Bug fix #11874

What changes did you make? (Give an overview)

This PR fixes the error message when people used --print-config with a directory path.

> eslint --print-config .     

Oops! Something went wrong! :(

ESLint: 6.0.0.

'--print-config' CLI option requires a path to a source code file rather than a directory.
See also: https://eslint.org/docs/user-guide/command-line-interface#--print-config

Is there anything you'd like reviewers to focus on?

Is this direction correct?

@mysticatea mysticatea added bug ESLint is working incorrectly evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Jun 23, 2019
@dywedir dywedir mentioned this pull request Jun 23, 2019
Merged
not-an-aardvark
not-an-aardvark approved these changes Jun 23, 2019
View reviewed changes
Copy link
Member

@not-an-aardvark not-an-aardvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I have a small suggestion to improve the error message.

messages/print-config-with-directory-path.txt Outdated Show resolved Hide resolved
@mysticatea @not-an-aardvark
Update messages/print-config-with-directory-path.txt
9a64844 
Co-Authored-By: Teddy Katz <teddy.katz@gmail.com>
@kaicataldo kaicataldo added accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly and removed bug ESLint is working incorrectly evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Jun 24, 2019
@platinumazure platinumazure added the patch candidate This issue may necessitate a patch release in the next few days label Jun 24, 2019
@platinumazure
Copy link
Member

Adding "patch candidate" label to ensure this gets in to the upcoming patch release (although this PR by itself would not normally justify a patch release).

@not-an-aardvark not-an-aardvark added the core Relates to ESLint's core APIs and features label Jun 24, 2019
@not-an-aardvark not-an-aardvark merged commit 13f0418 into master Jun 25, 2019
@not-an-aardvark not-an-aardvark deleted the issue11874 branch June 25, 2019 01:03
@snyk-bot snyk-bot mentioned this pull request Sep 15, 2019
Merged
@snyk-bot snyk-bot mentioned this pull request Oct 26, 2019
Open
This was referenced Nov 9, 2019
Open
Open
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Dec 23, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Dec 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@platinumazure platinumazure platinumazure approved these changes

@kaicataldo kaicataldo kaicataldo approved these changes

@not-an-aardvark not-an-aardvark not-an-aardvark approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly core Relates to ESLint's core APIs and features patch candidate This issue may necessitate a patch release in the next few days
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

eslint --print-config no longer works when given a directory
4 participants
@mysticatea @platinumazure @kaicataldo @not-an-aardvark